This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
aponcedeleonch
force-pushed
the
llamacpp-mux
branch
from
3f63b73 to
87f7218
Compare
jhrozek
previously approved these changes
Feb 3, 2025
aponcedeleonch
force-pushed
the
llamacpp-mux
branch
from
87f7218 to
50685d3
Compare
Closes: #883 There were a couple of nits that prevented support for llamacpp: 1. The `models` method was not implemented in the provider 2. A way of specifying the model outside `CompletionHandler` These PR takes care of both
aponcedeleonch
force-pushed
the
llamacpp-mux
branch
from
50685d3 to
0f9627a
Compare
jhrozek
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #883
There were a couple of nits that prevented support for llamacpp:
modelsmethod was not implemented in the providerCompletionHandlerThese PR takes care of both